feat: add package.json linter #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
achingbrain
requested changes
Dec 4, 2018
|
What do you think about adding |
|
i'm preparing another PR about git hooks to handle that and more. But im waiting for an automated way to overwrite the current git-validate we all have in our local repos. |
hugomrdias
force-pushed
the
feat/add-lint-package-json
branch
from
8d959d0
to
127cfd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds package.json linting with npm-package-json-lint and config for it.
Check this issue #303 for context about these changes, not all issues are solve in this PR but still improves the current situation.
//cc @ipfs/javascript-team