Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use peerid mismatch error type #29

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Aug 1, 2023

Uses the go-libp2p PR in libp2p/go-libp2p#2451.

Currently not mergeable as:

  1. It fails with QUIC connections since quic-go hides the underlying error type as described in feat: add ErrPeerIDMismatch error type to replace ad-hoc errors libp2p/go-libp2p#2451 (comment)
  2. The go-libp2p PR is just a PR

Update: These were both fixed and included in go-libp2p v0.31.0

Base automatically changed from chore/update-deps to main August 15, 2023 01:43
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #29 (ce085a2) into main (486ce55) will increase coverage by 1.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   42.23%   43.50%   +1.27%     
==========================================
  Files           4        4              
  Lines         322      308      -14     
==========================================
- Hits          136      134       -2     
+ Misses        154      143      -11     
+ Partials       32       31       -1     
Files Coverage Δ
lib/identify.go 60.00% <100.00%> (+7.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aschmahmann aschmahmann merged commit 3f29a32 into main Oct 19, 2023
4 checks passed
@aschmahmann aschmahmann deleted the feat/use-peerid-mismatch-err branch October 19, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants