Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mfs #5

Merged
merged 16 commits into from
Nov 13, 2015
Merged

Feat/mfs #5

merged 16 commits into from
Nov 13, 2015

Conversation

daviddias
Copy link
Member

TAP version 13
# piping a blob into a blob write stream
ok 1 no setup err
ok 2 null
ok 3 blob has key
ok 4 undefined
# reading a blob as a stream
ok 5 no setup err
ok 6 no blob write err
ok 7 blob has key
ok 8 blob length is correct
ok 9 undefined
# reading a blob that does not exist
ok 10 no setup err
ok 11 got a read stream err
ok 12 undefined
# check if a blob exists
ok 13 no setup err
ok 14 null
ok 15 does not exist
ok 16 no blob write err
ok 17 blob has key
ok 18 null
ok 19 exists
ok 20 undefined
# piping a blob into a blob write stream with string key
ok 21 no setup err
ok 22 null
ok 23 blob has key
ok 24 undefined
# reading a blob as a stream with string key
ok 25 no setup err
ok 26 no blob write err
ok 27 blob has key
ok 28 blob length is correct
ok 29 undefined
# reading a blob that does not exist with string key
ok 30 no setup err
ok 31 got a read stream err
ok 32 undefined
# check if a blob exists with string key
ok 33 no setup err
ok 34 null
ok 35 does not exist
ok 36 no blob write err
ok 37 blob has key
ok 38 null
ok 39 exists
ok 40 undefined
# blobs can be removed
ok 41 no setup err
ok 42 null
ok 43 undefined
ok 44 null
ok 45 blob is removed

1..45
# tests 45
# pass  45

# ok

@daviddias daviddias mentioned this pull request Nov 9, 2015
11 tasks

module.exports = function (node) {
var store = {}
var baseDir = '/npm-registry/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be configurable and passed in, or does the baseDir not really matter too much and can be basically be any string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch! I was doing experiments with reginabox and forgot about this.

@daviddias
Copy link
Member Author

Thanks for the CR @travisperson :)

Will merge now.

daviddias added a commit that referenced this pull request Nov 13, 2015
@daviddias daviddias merged commit 47a7311 into master Nov 13, 2015
@daviddias daviddias deleted the feat/mfs branch November 13, 2015 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants