-
Notifications
You must be signed in to change notification settings - Fork 41
perf: use svg sprites & urls instead of all inline #122
Conversation
cc13c83
to
484146b
Compare
I wanted to make separate PRs for everything but I had no time. Additionally, I will follow up more improvements after DWeb. |
@satazor merge conflicts |
7c19f1f
to
6fa57ea
Compare
@PedroMiguelSS can you handle the merge conflicts of this one? Hoping to see this published today. |
I've rebased again. Here's a screenshot of the before and after: There's still more minor improvements to do. We need to do that as part of #69 |
@PedroMiguelSS can we please merge this asap to avoid more conflicts? Please review the PR carefully as there is a lot of changes. I'm sorry to not split it into more PRs but I really didn't have the time. |
6b887c5
to
82c906c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems good to me! @PedroMiguelSS will double check and test it 🙂
5ea4ad3
to
4e25c9c
Compare
221bd1b
to
6da5615
Compare
- Moved images to folders closest to components, allowing for future optimizations with sprites - Renamed some files, variables and data - Fixed footer element placements - Fixed code consistenty with spaces in some files - Removed locale utils, it's not necessary at alls - Removed unused data files - Improved css modules hash in production - Improved videos sections hover animations - Fixed play icon being loaded from imgur instead of IPFS - Used standard transitions whenever possible
6da5615
to
ae8e2c8
Compare
Refs #69