This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
WIP cat interface core #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| }) | ||
| }) | ||
| test.files(common) |
There was a problem hiding this comment.
Note to self: once I get in the add test PR, rename this file to files-spec.js, so we don't run the interface files tests twice.
There was a problem hiding this comment.
thought of this as well, but calling it file.spec.js since files.spec.js is taken by the mfs tests
There was a problem hiding this comment.
Wasn't there an issue somewhere about explicitly renaming that to mfs across js-ipfs? Having trouble finding that..
|
🐴 LGTM |
| @@ -4,6 +4,7 @@ const argCommand = require('../cmd-helpers').argCommand | |||
|
|
|||
| module.exports = (send) => { | |||
| return { | |||
| cat: argCommand(send, 'cat'), | |||
There was a problem hiding this comment.
this is a mistake, should not be here
| return cat | ||
| } | ||
|
|
||
| function cleanMultihash (multihash) { |
There was a problem hiding this comment.
I think this is defined in src/api/object.js too. Could you toss it into a module in src/?
|
closing in favor of #292 where others can edit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins the js-ipfs-api cat command using the interace-core tests shared with the js-ipfs core tests.
This needs the completition of the cat interface-core PR