This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Added Group id
#30
Merged
Added Group id
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <pubkey>: public key | ||
| <addrs>: addresses (newline delimited) | ||
|
|
||
| ## id [GET /id{?arg}{&format}] |
There was a problem hiding this comment.
Wouldn't it be better if the format is something that the cli understand and transforms the json coming from the API?
There was a problem hiding this comment.
TBH, I can't get the format tag working at all!
Example that should work:
curl -i -X POST http://localhost:5001/api/v0/id?arg=QmepgFW7BHEtU4pZJdxaNiv75mKLLRQnPi1KaaXmQN4V1a&format="<addrs>"
There was a problem hiding this comment.
@whyrusleeping is the format really part of the API? It should be just the cli that prints out depending on the requested format, right?
There was a problem hiding this comment.
ping @whyrusleeping
|
Other than the |
|
Needs to be checked before #20 can be closed. |
|
It looks like format is only used client side to format the json blob we get back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to get
&formatworking. Any ideas?