-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
Suggested version: Changes in diff --git a/go.mod b/go.mod
index cd31926..8781520 100644
--- a/go.mod
+++ b/go.mod
@@ -4,23 +4,22 @@ go 1.19
require (
github.com/cskr/pubsub v1.0.2
- github.com/filecoin-saturn/caboose v0.0.2
- github.com/gogo/protobuf v1.3.2
+ github.com/filecoin-saturn/caboose v0.0.3
github.com/hashicorp/golang-lru/v2 v2.0.1
- github.com/ipfs/boxo v0.8.2-0.20230530204310-0dcbaccc3745
+ github.com/ipfs/boxo v0.10.2-0.20230627114119-8424cf4e020a
github.com/ipfs/go-block-format v0.1.2
- github.com/ipfs/go-cid v0.4.0
- github.com/ipfs/go-ipld-format v0.4.1-0.20230530195241-c3da01c74a06
+ github.com/ipfs/go-cid v0.4.1
+ github.com/ipfs/go-ipld-format v0.5.0
github.com/ipfs/go-log/v2 v2.5.1
- github.com/ipfs/go-unixfsnode v1.6.0
+ github.com/ipfs/go-unixfsnode v1.7.1
github.com/ipld/go-codec-dagpb v1.6.0
github.com/ipld/go-ipld-prime v0.20.0
github.com/libp2p/go-libp2p v0.26.3
- github.com/libp2p/go-libp2p-kad-dht v0.21.1
- github.com/libp2p/go-libp2p-routing-helpers v0.4.0
+ github.com/libp2p/go-libp2p-kad-dht v0.23.0
+ github.com/libp2p/go-libp2p-routing-helpers v0.7.0
github.com/mitchellh/go-server-timing v1.0.1
- github.com/multiformats/go-multicodec v0.8.1
- github.com/multiformats/go-multihash v0.2.1
+ github.com/multiformats/go-multicodec v0.9.0
+ github.com/multiformats/go-multihash v0.2.3
github.com/prometheus/client_golang v1.15.1
github.com/rs/dnscache v0.0.0-20211102005908-e0241e321417
github.com/spf13/cobra v1.6.1
@@ -58,6 +57,7 @@ require (
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 // indirect
github.com/godbus/dbus/v5 v5.1.0 // indirect
+ github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/gddo v0.0.0-20180823221919-9d8ff1c67be5 // indirect
github.com/golang/mock v1.6.0 // indirect
github.com/golang/protobuf v1.5.3 // indirect
@@ -82,7 +82,6 @@ require (
github.com/ipfs/go-ipfs-util v0.0.2 // indirect
github.com/ipfs/go-ipld-cbor v0.0.6 // indirect
github.com/ipfs/go-ipld-legacy v0.2.1 // indirect
- github.com/ipfs/go-ipns v0.3.0 // indirect
github.com/ipfs/go-libipfs v0.6.0 // indirect
github.com/ipfs/go-log v1.0.5 // indirect
github.com/ipfs/go-merkledag v0.10.1-0.20230601163447-eceea556e7d4 // indirect
@@ -120,7 +119,7 @@ require (
github.com/multiformats/go-multiaddr v0.8.0 // indirect
github.com/multiformats/go-multiaddr-dns v0.3.1 // indirect
github.com/multiformats/go-multiaddr-fmt v0.1.0 // indirect
- github.com/multiformats/go-multibase v0.1.1 // indirect
+ github.com/multiformats/go-multibase v0.2.0 // indirect
github.com/multiformats/go-multistream v0.4.1 // indirect
github.com/multiformats/go-varint v0.0.7 // indirect
github.com/onsi/ginkgo/v2 v2.5.1 // indirect
@@ -177,6 +176,7 @@ require (
golang.org/x/text v0.7.0 // indirect
golang.org/x/tools v0.5.0 // indirect
golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
+ gonum.org/v1/gonum v0.11.0 // indirect
google.golang.org/genproto v0.0.0-20230110181048-76db0878b65f // indirect
google.golang.org/grpc v1.53.0 // indirect
google.golang.org/protobuf v1.30.0 // indirect
Automatically created GitHub ReleaseA draft GitHub Release has been created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not seem to work for me locally, basic smoke test with http://en.wikipedia-on-ipfs.org.ipns.localhost:8081/wiki/Belize/ does not work:
I tested with GOLOG_LOG_LEVEL="debug" STRN_ORCHESTRATOR_URL="https://orchestrator.strn.pl/nodes/nearby?count=100" GRAPH_BACKEND=true go run .
and it errors:
2023-07-13T15:36:51.093Z WARN caboose caboose@v0.0.3/pool.go:64 failed to decode backends from orchestrator {"err": "json: cannot unmarshal string into Go value of type tieredhashing.NodeInfo", "endpoint": "https://orchestrator.strn.pl/nodes/nearby?count=100"}
This seems to be a regression, I've built v0.0.12
and it works fine, reads L1s correctly:
2023-07-13T15:43:32.630Z INFO caboose caboose@v0.0.2/pool.go:52 got backends from orchestrators {"cnt": 100, "endpoint": "https://orchestrator.strn.pl/nodes/nearby?count=100"}
I am building with go 1.20.3, lmk if i am missing anything.
@lidel Thanks for running the test. I believe the orchestrator endpoint is deprecated (https://orchestrator.strn.pl/nodes/nearby?count=100) and requires to be updated. This corresponds to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, here the default Orchestrator URL changed, it returns different JSON schema now.
With STRN_ORCHESTRATOR_URL="https://orchestrator.strn.pl/nodes?maxNodes=200"
the error is gone.
@AmeanAsad I think all is good in this repo (i've removed hardcoded STRN_ORCHESTRATOR_URL
a while ago), but cc @gmasgras for visibility when this is deployed to prod, as we need to make sure this STRN_ORCHESTRATOR_URL
change is applied to YAML in bifrost-infra repo in places like this one.
ps.
Is Saturn backend suffering perf issues today? Running with STRN_ORCHESTRATOR_URL
backend is effectively unusable. Opening even the smallest website like http://docs.ipfs.tech.ipns.localhost:8081/ takes ages, CAR requests error with 2023-07-13T18:12:28.490+0200 INFO backend/graph lib/graph_gateway.go:332 car Fetch failed {"path": "/ipfs/QmTyS43Vbwht5LE8bvPP4nZmWYyc7iafweD6zJhJhGmAJa/assets/js/103.3c34f29b.js?format=car&dag-scope=block", "error": "empty car, no roots"}
but then fallback to block-by-block and eventually load.
I've tested with Kubo 0.21 and PROXY_GATEWAY_URL="http://127.0.0.1:8080"
and works fine, so ok with me to release.
I assume Saturn backend is optimized for Rhea, and takes a while to build L1 reputation and not self-hosting (which is fine, I only care about PROXY_GATEWAY_URL
not regressing), but wanted to flag, as the empty cache perf was not THAT BAD in the past.
No description provided.