feat: add helia-car-creator example #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
changed the title
SgtPooki
changed the title
|
failing test shows different car file CID, see https://github.com/ipfs-examples/helia-examples/actions/runs/5696092971/job/15440516463?pr=72#step:6:135
https://cid.ipfs.tech/#bafybeiczsscdsbs7ffqz55asqdf3smv6klcw3gofszvwlyarci47bgf354 shows
https://cid.ipfs.tech/#bafybeifsknwjwoby7gmnqlzj236rcq47q5pskkum7svsevsod5a74caxry shows
|
|
there is definitely something sketchy going on somewhere. assuming something with playwright downloads |
|
made some changes, and then ran > hyperfine 'npm run test' --show-output --ignore-failure --export-json=./testRuns.json --runs=1000 | tee testRuns.txt
[...]
> cat testRuns.json | jq '.results[0].exit_codes | {total: . | length, failed: map(select(. == 0|not)) | length }'
{
"total": 1000,
"failed": 0
} |
whizzzkid
approved these changes
Jul 29, 2023
Comment on lines
+4
to
+8
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
| lerna-debug.log* |
There was a problem hiding this comment.
idk why these were all there. probably from the other example i copied from
| const downloadEl = document.createElement('a') | ||
| const blobUrl = window.URL.createObjectURL(carBlob) | ||
| downloadEl.href = blobUrl | ||
| downloadEl.download = 'test.car' |
There was a problem hiding this comment.
Can we just call it the <original_file_name>.car?
There was a problem hiding this comment.
We could (or first filename if multiple), but I think that's a minor thing anyone running/improving this example could do easily. will sleep on this one
|
|
||
| const { writer, out } = await CarWriter.create(rootCID) | ||
|
|
||
| // don't await yet.. |
| return car(helia) | ||
| }, [helia]) | ||
| const heliaFs = useMemo(() => { | ||
| if (helia == null) { |
There was a problem hiding this comment.
Can/Should this be DRYer?
| export default function FileUploader () { | ||
| const { files, setFiles } = useFiles() | ||
| const handleFileEvent = useCallback((e) => { | ||
| const filesToUpload = Array.prototype.slice.call(e.target.files) |
There was a problem hiding this comment.
I personally find this very hacky, isn't e.target.files already an array?
There was a problem hiding this comment.
it's not quite an array but I haven't looked at this part of the code in a while, I will look again
Comment on lines
+28
to
+46
| if (helia) { | ||
| console.info('helia already started') | ||
| } else if (window.helia) { | ||
| console.info('found a windowed instance of helia, populating ...') | ||
| setHelia(window.helia) | ||
| setFs(unixfs(helia)) | ||
| setStarting(false) | ||
| } else { | ||
| try { | ||
| console.info('Starting Helia') | ||
| const helia = await createHelia() | ||
| setHelia(helia) | ||
| setFs(unixfs(helia)) | ||
| setStarting(false) | ||
| } catch (e) { | ||
| console.error(e) | ||
| setError(true) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (helia) { | |
| console.info('helia already started') | |
| } else if (window.helia) { | |
| console.info('found a windowed instance of helia, populating ...') | |
| setHelia(window.helia) | |
| setFs(unixfs(helia)) | |
| setStarting(false) | |
| } else { | |
| try { | |
| console.info('Starting Helia') | |
| const helia = await createHelia() | |
| setHelia(helia) | |
| setFs(unixfs(helia)) | |
| setStarting(false) | |
| } catch (e) { | |
| console.error(e) | |
| setError(true) | |
| } | |
| } | |
| if (helia) { | |
| console.info('helia already started') | |
| return | |
| } | |
| try { | |
| const heliaInstance = window.helia || await createHelia() | |
| setHelia(heliaInstance) | |
| setFs(unixfs(helia)) | |
| setStarting(false) | |
| } catch (e) { | |
| console.error(e) | |
| setError(true) | |
| } |
There was a problem hiding this comment.
this was copied from helia-vite IIRC, will test this update tomorrow
| export const HeliaProvider = ({ children }) => { | ||
| const [helia, setHelia] = useState(null) | ||
| const [fs, setFs] = useState(null) | ||
| const [starting, setStarting] = useState(true) |
There was a problem hiding this comment.
I'm not seeing the value of this, can't just access to the instance help?
| line-height: 1.5; | ||
| font-weight: 400; | ||
|
|
||
| color-scheme: light dark; |
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This example was created to assist some folks in ETHGlobal HackFS 2023 who were asking questions about how to build CAR files out of files uploaded by a user.
Things left to do: