feat: add Helia Angular example #309
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
examples/helia-angular/.editorconfig
Outdated
| # Editor configuration, see https://editorconfig.org | ||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| indent_style = space | ||
| indent_size = 2 | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [*.ts] | ||
| quote_type = single | ||
|
|
||
| [*.md] | ||
| max_line_length = off | ||
| trim_trailing_whitespace = false |
There was a problem hiding this comment.
just to keep things normalized in examples, we should remove this
examples/helia-angular/README.md
Outdated
| @@ -0,0 +1,27 @@ | |||
| # HeliaAngular | |||
There was a problem hiding this comment.
we should update the readme to match language of other examples. e.g. https://github.com/ipfs-examples/helia-examples/blob/56a4790086c39dd635e230135d4a774cbd4783ce/examples/helia-jest/README.md
most important are the sections below (and including) the About the project section
There was a problem hiding this comment.
we should reduce a lot of this angular specific styling to focus on keeping a similar style as our other examples, like https://github.com/ipfs-examples/helia-examples/blob/56a4790086c39dd635e230135d4a774cbd4783ce/examples/helia-vite/src/index.css
| @@ -0,0 +1 @@ | |||
| /* You can add global styles to this file, and also import other style files */ | |||
There was a problem hiding this comment.
we should use the same styles as our other examples. one example: /examples/helia-vite/src/index.css
achingbrain
changed the title
achingbrain
changed the title
|
@paschal533 thanks so much for opening this - do you have some time to address @SgtPooki's review comments? |
I totally forgot 🤦. Let me work on it right away. Thank you so much. |
|
@SgtPooki Thank you for taking the time to review this pull request and providing such insightful suggestions. The necessary changes have been made accordingly. |
|
I tested this locally again and tried making some improvements, but no matter what I do Chrome will crash the page for some reason. I am thinking it's the WebTransport errors because it doesn't happen in FF |
I added how to implement helia in an Angular project