New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single pubsub and blacklist #37

Merged

dustinxie merged 3 commits into iotexproject:master from envestcc:refactor_blacklist

Mar 8, 2023

Member

envestcc commented Mar 6, 2023 •

edited

Loading

Why

It's unnecessary to provide a separate blacklist to every topic. Actually blacklist is used to block peer when it trigger rate limit, however the rate limit triggered for all topics together.
By using a single pubsub, the complexity of implementing publishing unsubscribed topic messages can be reduced.

envestcc added 2 commits

March 6, 2023 18:08


          use global blacklist

7f684bb


          use single pubsub

4847f0c

Liuhaai approved these changes

View reviewed changes


          remove newPubsub

83d4e6e

dustinxie merged commit a173650 into iotexproject:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet