Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special handling for ionic-native #2

Closed
rapropos opened this issue Jun 19, 2017 · 5 comments
Closed

special handling for ionic-native #2

rapropos opened this issue Jun 19, 2017 · 5 comments

Comments

@rapropos
Copy link

Perhaps a warning and link to the v3 upgrade guide would be helpful if "ionic-native" is found as a dependency. There is also a major cliff at 3.6.0, where if the app has any pre-3.6 @ionic-native/plugin packages, and we are going to upgrade @ionic-native/core past 3.6, I believe it would be highly indicated to bring all ionic-native packages up past 3.6 as well. One could make the argument that it would always be helpful to try upgrading all ionic-native packages to match whatever version of core is being recommended, but maybe that's overly aggressive.

@janpio
Copy link
Collaborator

janpio commented Jun 22, 2017

I have this feature on my list a "Important Changes".

Right now I imagine a JSON that contains the package names, "cliff version" numbers and messages that, if "updated over" the "cliff version" triggers the "message" to be displayed in this list. Example:

package cliff version message
@ionic-native/core 3.6.0 You should upgrade all other ionic-native packages as well

Problem is this won't work for the ionic-native => @ionic-native/core for example, so I should probably think about this some more - or just implement it in some super hackish way that just works.

Do you see other "Important Changes" to be done by the users besides ionic-native stuff?

@janpio
Copy link
Collaborator

janpio commented Jun 22, 2017

One could make the argument that it would always be helpful to try upgrading all ionic-native packages to match whatever version of core is being recommended, but maybe that's overly aggressive.

I am undecided on that as well, but I think I will wait until I have some real world package.json data to see how many packages people use. As documentation of ionic-native is not archived and in general everything is pretty... "fluid" (as in unstable) in there, I am not sure if this would hurt more than help.

@janpio
Copy link
Collaborator

janpio commented Jan 18, 2018

Hey @rapropos , do you remember what caused this 3.6 cliff for Ionic Native? Result is "just" that all packages have to uprgaded above 3.6 while it is ok to have different versions in general if they are all <3.6 or >3.6, right?

@janpio
Copy link
Collaborator

janpio commented Jan 18, 2018

I think I found the responsible Ionic Native change: danielsogl/awesome-cordova-plugins#1425

@janpio
Copy link
Collaborator

janpio commented Jan 24, 2018

Now implemented at https://update.ionic.zone/
(minus the cliff, because I am not 100% sure why this is happening and so couldn't give a good reason.)

@janpio janpio closed this as completed Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants