Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneSignal improvements #352

Merged
merged 11 commits into from
Jul 25, 2016
Merged

OneSignal improvements #352

merged 11 commits into from
Jul 25, 2016

Conversation

aaronczichon
Copy link
Contributor

Two OneSignal changes:

  • Changed init function to support notificationOpenedCallback as an optional parameter
  • Removed platform specification

Aaron Czichon and others added 10 commits June 27, 2016 18:59
extended init function with notificationOpenedCallback as an optional parameter
OneSignal supports more than only these 3 platforms. It's available to nearly all Cordova platforms.
@ihadeed
Copy link
Collaborator

ihadeed commented Jul 25, 2016

Hey there,

Why did you change the Promise to a Callback?

Is it because that callback gets triggered multiple times? If that's the case we can convert the return type to an Observable instead.

@aaronczichon
Copy link
Contributor Author

Hi,

yes it's not trigged during the application run. It's triggered when a notification was received, which can be occures multiple times. Observable could be a solution.

@ihadeed
Copy link
Collaborator

ihadeed commented Jul 25, 2016

@Corova({
  observable: true
})
static methodName(): Observable<any> {return; }

@aaronczichon
Copy link
Contributor Author

Changed it to an observable.

@ihadeed ihadeed merged commit 08fe04e into danielsogl:master Jul 25, 2016
@ihadeed
Copy link
Collaborator

ihadeed commented Jul 25, 2016

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants