-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for fixing missing methods issue #3491 #3517
Conversation
fix: Remove unnecessary adder .scripts Folder fix: Remove unwanted added folder .circleci fix: Remove unwanted added File .npmrc fix: Revert .Github Folder Changes to as per Ionic-Native master fix: Update changes as per ionic-native master
@danielsogl Can someone help here? |
@danielsogl Our clients are waiting for this release. Can we get some response at least? Some sort of an ETA on when will these changes be merged? |
@darshanclevertap can you rebase your commits instead of just merging in the changes? The commit history looks a bit messy here. Also, Ionic native is community driven, meaning people help out when they can. You do not need to ping Daniel to get his attention. Clean up the commit history, and it should be good to go from there. |
@mhartington Thanks for reaching out. I've updated the code, tried to rebase the commits as well, not sure what was expected of me. Do I need to squash merging commits or just a normal |
@mhartington Any update here? |
@mhartington Can we close this soon? |
Is the PR correct? Just removing 4 methods from the plugin? |
@mhartington Yes, because they were added twice and because of this the methods were unusable |
No description provided.