Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onesignal): add in-app messages methods #3481

Merged
merged 1 commit into from
Aug 14, 2020
Merged

feat(onesignal): add in-app messages methods #3481

merged 1 commit into from
Aug 14, 2020

Conversation

cristianofromagio
Copy link
Contributor

Fix issue #3478

On the documentation the OSInAppMessageAction Class is listed as being camelCase but the result properties of the Cordova SDK method that I tested returns snake_case (likely inspired by a json conversion as also seem on the Flutter SDK), so I opted to set the interface with the snake_case notation.

Example of a tested OSInAppMessageAction result object:

[ng] [console.log]: "in-app message clicked"
[ng] [console.log]: {
[ng]   "click_url": "",
[ng]   "first_click": true,
[ng]   "closes_message": true,
[ng]   "outcomes": []
[ng] }

@danielsogl danielsogl self-assigned this Aug 14, 2020
@danielsogl danielsogl added the target: minor This PR is targeted for the next minor release label Aug 14, 2020
@danielsogl danielsogl merged commit eec3fec into danielsogl:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants