Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(geolocation): #3303 geolocation watchPosition return type #3470

Merged
merged 2 commits into from
Aug 14, 2020
Merged

fix(geolocation): #3303 geolocation watchPosition return type #3470

merged 2 commits into from
Aug 14, 2020

Conversation

DavidWiesner
Copy link
Contributor

The return type of watchPosition is wrong. Geoposition and PositionError will pass to the Observable. Therefore the return type has to be changed to reflect this behavior.

Fixes

#3303

@DavidWiesner DavidWiesner changed the title fix #3303 geolocation watchPosition return type fix(geolocation): #3303 geolocation watchPosition return type Jun 24, 2020
@DavidWiesner
Copy link
Contributor Author

I think you should the error instead of returning possible types. I mixed up Subject and Observable

@DavidWiesner
Copy link
Contributor Author

Ok I read the the Rxjs contract again. There should be only one error. So my fix is right.

@DavidWiesner DavidWiesner reopened this Jun 25, 2020
@danielsogl danielsogl self-assigned this Aug 14, 2020
@danielsogl danielsogl added the target: patch This PR is targeted for the next patch release label Aug 14, 2020
@danielsogl danielsogl merged commit 579170a into danielsogl:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsogl danielsogl danielsogl approved these changes

Assignees

@danielsogl danielsogl

Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidWiesner @danielsogl