Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Secure Storage #347

Merged
merged 4 commits into from
Jul 23, 2016
Merged

Add Secure Storage #347

merged 4 commits into from
Jul 23, 2016

Conversation

begriffin
Copy link
Contributor

* @param storage {string}
*/
constructor(storage: string) {
let res, rej
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot ;

@ihadeed
Copy link
Collaborator

ihadeed commented Jul 22, 2016

Read the comments.

Also I think we should follow what Max did with the SQLite plugin here: f1c8ce3

This way we can keep the ionic-native modifications consistent.

The usage would be something like:

let secureStorage: SecureStorage = new SecureStorage();
secureStorage.create(<options>).then(<onSuccess>).catch(<onError>);

…c-native plugins.

Edited comments to reflect changes.

// Properties
private _objectInstance: any;
init: Promise<any>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unecessary now

@ihadeed
Copy link
Collaborator

ihadeed commented Jul 23, 2016

Looks good @begriffin
Thank you for the PR!

@ihadeed ihadeed merged commit 075842d into danielsogl:master Jul 23, 2016
@ihadeed
Copy link
Collaborator

ihadeed commented Jul 23, 2016

I'm thinking the create function should be refactored to something like openStorage. Since that function would open the database if the name exists. (similar to SQLite behaviour).

What do you guys think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants