fix(firebase-x): indicate callback methods to verifyPhoneNumber

[vdias38]

indicate callback methods to verifyPhoneNumber and signInWithCredential functions.

Definition for the non-ionic methods are available as
https://github.com/dpa99c/cordova-plugin-firebasex/blob/master/types/index.d.ts#L120

[Sampath-Lokuge]

Hi @vdias38 Can we have release using this change?

[vdias38]

Hi @vdias38 Can we have release using this change?

I hope, but should wait owners to merge it, or use my branch... humm or not. Should wait for merge because you should install compiled code. If urgent, let me know and I'll find a way to share with you a compiled version.

[Sampath-Lokuge]

Thanks, @vdias38 I'll wait till the official release.

[CalumMurray]

Partially duplicates #3443

[vdias38]

Partially duplicates #3443

Hi @CalumMurray , it's not exactly the same, I don't understand why you use callbacks as arguments and how/why you use them.
As far as I understand to use callbacks you can use directly the plugin interface. The ionic-native provides an interface to replace callbacks by Promise or Observable, then verifyPhoneNumber for example, could be called as below:

this.firebaseX.verifyPhoneNumber(phone, this.timeOutDuration)
.then( credential => {...})
.catch(error => {...})

Implementation above is compatible with following declaration I've submitted to ionic-native, but not with yours.

  @Cordova({
    callbackOrder: 'reverse'
  })
  verifyPhoneNumber(
    phoneNumber: string,
    timeOutDuration: number,
    fakeVerificationCode?: string
  ): Promise<any> {
    return;
  }

Make sense or do I miss something?
Following same logic I've added signOutUser on this #3458

[CalumMurray]

Hi @vdias38, I think you're right. I had assumed they were removed during some build step perhaps as other had left the success/error callbacks in, so I also left them. Thanks for adding signOutUser(). Since yours is more complete, I think this can replace my PR #3443