-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firebase-x): add getCurrentUser #3389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add getCurrentUser method. fixes danielsogl#3356
danielsogl
approved these changes
May 5, 2020
@akshaydwivedi29 please resolve the conflicts |
danielsogl
added
needs reply
target: patch
This PR is targeted for the next patch release
labels
May 5, 2020
@danielsogl done! |
danielsogl
approved these changes
May 9, 2020
@danielsogl will it soon be merged? just confirming. thanks! |
@akshaydwivedi29 The conflicts are still there. |
@danielsogl it's just one empty line vs my new commit. not able to do anything as git is not recognizing any further changes on the file. |
Kardeşim ne zaman çözülcek ? Müşteri bekliyor allah allah... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add getCurrentUser method. fixes #3356