Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vibes-push-plugin): add Vibes Push plugin wrapper #3368

Merged
merged 1 commit into from
May 5, 2020

Conversation

Ashaba
Copy link
Contributor

@Ashaba Ashaba commented Apr 6, 2020

This adds an Ionic Native Wrapper for the cordova vibes plugin(https://github.com/vibes/vibes-cordova.git). The plugin enables integration with the Vibes platform.

Copy link
Owner

@danielsogl danielsogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide promis callback interfaces or just a Promise<void> as return type if the callback is empty.

@danielsogl danielsogl self-assigned this Apr 15, 2020
@danielsogl danielsogl added the target: minor This PR is targeted for the next minor release label Apr 15, 2020
@Ashaba Ashaba force-pushed the master branch 4 times, most recently from 348d954 to b8bbe21 Compare April 23, 2020 18:24
@Ashaba
Copy link
Contributor Author

Ashaba commented Apr 23, 2020

changes incorporated @danielsogl

@danielsogl danielsogl merged commit 1db0ff7 into danielsogl:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants