Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contacts): missing name property, types #320

Merged
merged 1 commit into from
Jul 18, 2016
Merged

fix(contacts): missing name property, types #320

merged 1 commit into from
Jul 18, 2016

Conversation

Manduro
Copy link
Contributor

@Manduro Manduro commented Jul 17, 2016

The @InstanceProperty for name was missing. This made it impossible to set the name of a contact properly, rendering this plugin pretty much useless for creating contacts.

There were also some type issues:

  1. nickname should be type string
  2. phoneNumbers should be type IContactField[]
  3. All types should use interfaces, as the objects themselves have an _objectInstance property.
  4. Contact should implement IContactProperties

These bugs came in at v1.3.0, where this plugin was refactored, although the changelog does not mention this.

@ihadeed ihadeed merged commit 074d166 into danielsogl:master Jul 18, 2016
@ihadeed
Copy link
Collaborator

ihadeed commented Jul 18, 2016

thanks @Manduro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants