feat(in-app-purchase-2): update TypeScript definitions #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsogl
approved these changes
May 27, 2019
danielsogl
added
the
target: patch
|
@j3k0 thanks for your PR! I tested with new version 5.7.0 of ionic native but I have a problem with it :) All your properties are set as REQUIRED. So is it really necessary to add every property? If not (and I think it's not required), make the properties optional. For example:
It's easy by adding the question mark (https://www.typescriptlang.org/docs/handbook/interfaces.html) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I'm the maintainer of
cordova-plugin-purchase, the cordova plugin used byin-app-purchase-2. I made some changes requested by users to the TypeScript definition, but I'm not ionic developer, I'm new to TypeScript, and don't know how to test the changes ;-)Looks simple and it should probably work, but it'd be better to actually try it!
On a different note: how to update the page https://ionicframework.com/docs/native/in-app-purchase-2 ? The plugin now supports macOS and Microsoft UWP, plus it'd be nice to show more documentation, I can probably help with that.