Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): add deprecation notice for all electron commands #3268

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

jcesarmobile
Copy link
Member

#3263 is only warning in add, so will only on new projects or users adding electron for the first time, but existing electron users won't notice and they need to move too because all commands are being removed in v3.

So this PR adds the deprecation notice in all electron commands

Copy link
Contributor

@IT-MikeS IT-MikeS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good catch, better to have the warning on all of the commands. 👍

@imhoffd imhoffd merged commit 5e84ce9 into ionic-team:master Jul 15, 2020
@imhoffd imhoffd deleted the more-electron-warnings branch July 15, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants