-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): Add Statusbar.setOverlaysWebView method #2597
Merged
jcesarmobile
merged 10 commits into
ionic-team:master
from
Crylion:statusbar-overlayswebview
Mar 19, 2020
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b985032
feat(android): add method to statusbar to overlay webview (#1876)
Crylion 90d3ae1
docs(Statusbar): Add example for overlaysWebview method
Crylion 81bf08d
docs(Statusbar): fix typo in example comment
Crylion 7645db5
fix(android): change parameter name to be more readable
Crylion 63735b4
feat(android): include overlay status in getInfo() response
Crylion b01c0ed
feat(android): save and restore status bar color when necessary
Crylion 73299b1
fix(android): remove annotation from color field
Crylion cf90e82
fix(android): change name of attribute in information return value
Crylion 936da9a
fix(ios): add method to ios bridge definition
Crylion 2d723ff
docs(Statusbar): fix wrong parameter name and missing semicolon
Crylion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -49,6 +49,11 @@ export class StatusBarExample { | |||||
style: this.isStatusBarLight ? StatusBarStyle.Dark : StatusBarStyle.Light | ||||||
}); | ||||||
this.isStatusBarLight = !this.isStatusBarLight; | ||||||
|
||||||
// Display content unter transparent status bar (Android only) | ||||||
Statusbar.setOverlaysWebView({ | ||||||
enabled: true | ||||||
}) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing ; at the end
Suggested change
|
||||||
} | ||||||
|
||||||
hideStatusBar() { | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to change the new name here