feat(clipboard): allow to write images on web plugin #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwespi
reviewed
Mar 4, 2020
| @@ -22,10 +23,24 @@ export class ClipboardPluginWeb extends WebPlugin implements ClipboardPlugin { | |||
| return Promise.reject('Clipboard API not available in this browser'); | |||
| } | |||
|
|
|||
| if (options.string !== undefined || options.url) { | |||
There was a problem hiding this comment.
@jcesarmobile Have you changed this line on purpose? This might have reintroduced issue #2366
There was a problem hiding this comment.
Oops, sorry, will fix it tomorrow as I’m working in other clipboard changes
There was a problem hiding this comment.
should be fixed again by #2527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows clipboard plugin to write images
Also fixes read of images, which wasn't working