Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: double test timeouts on arm machines #1357

Merged
merged 1 commit into from
Apr 7, 2015

Conversation

bnoordhuis
Copy link
Member

The ARM buildbots are notoriously slow. Update the test runner to
double the per-test time limit when it's running on one of them.

R=@iojs/build

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/448/

@Fishrock123
Copy link
Contributor

cc @silverwind

@brendanashworth brendanashworth added the test Issues and PRs related to the tests. label Apr 6, 2015
@brendanashworth
Copy link
Contributor

Build 444 on armv8 looks like it had the same amount of timeouts as this build's, fwiw.

@silverwind
Copy link
Contributor

Is this the 30s test time limit? On which boards is it an issue?

@bnoordhuis bnoordhuis mentioned this pull request Apr 6, 2015
@bnoordhuis
Copy link
Member Author

Is this the 30s test time limit?

Yes. Specifically, the limit that makes tests fail with --- TIMEOUT ---.

On which boards is it an issue?

The ARMv8 buildbot is the main offender and I noticed that's the one buildbot that seems unaffected by this change. I speculate that platform.machine() returns something different on that one. Will investigate.

@bnoordhuis
Copy link
Member Author

I speculate that platform.machine() returns something different

It does: 'aarch64'. New run with fix-up: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/455/

@bnoordhuis
Copy link
Member Author

The latest run suggests that the timeouts are persistent, doubling doesn't make a difference. I'm going to close this PR.

@bnoordhuis bnoordhuis closed this Apr 7, 2015
@silverwind
Copy link
Contributor

Yeah, I wondered myself if that was really needed, as ARMv7 (RPi2) is almost fast enough to pass tests without any modifications. I expect ARMv8 to pass with our regular timeouts.

@bnoordhuis
Copy link
Member Author

I did some digging and I expect that libuv is to blame here, see libuv/libuv#308.

The ARM buildbots are notoriously slow.  Update the test runner to
double the per-test time limit when it's running on one of them.

PR-URL: nodejs#1357
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

@bnoordhuis ARMv6 seems to hit the 30s timeout on the following tests:

test/sequential/test-pipe
test/parallel/test-stringbytes-external

That'd be two tests I can strike off my ARMv6 list if this gets merged. Would you reconsider this PR for these?

@bnoordhuis
Copy link
Member Author

Oh, sure. The branch still exists. If you LGTM it, I'll land it.

@silverwind silverwind reopened this Apr 7, 2015
@silverwind
Copy link
Contributor

LGTM. Just ran the ARMv6 tests with this patch, and no more --- TIMEOUT --- 👍

@bnoordhuis bnoordhuis closed this Apr 7, 2015
@bnoordhuis bnoordhuis deleted the arm-double-test-timeout branch April 7, 2015 17:59
@bnoordhuis bnoordhuis merged commit 3066f2c into nodejs:v1.x Apr 7, 2015
@rvagg rvagg mentioned this pull request Apr 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants