Skip to content

Commit

Permalink
src: silence clang warnings
Browse files Browse the repository at this point in the history
Mark several methods "override" in order to remove build warnings.

PR-URL: #531
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
trevnorris committed Jan 20, 2015
1 parent 22e1aea commit 752585d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/node_v8_platform.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ class Platform : public v8::Platform {
virtual ~Platform() override;

void CallOnBackgroundThread(v8::Task* task,
ExpectedRuntime expected_runtime);
void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task);
double MonotonicallyIncreasingTime();
ExpectedRuntime expected_runtime) override;
void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task) override;
double MonotonicallyIncreasingTime() override;

protected:
static void WorkerBody(void* arg);
Expand Down
4 changes: 2 additions & 2 deletions src/string_bytes.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ class ExternString: public ResourceType {
isolate()->AdjustAmountOfExternalAllocatedMemory(change_in_bytes);
}

const TypeName* data() const {
const TypeName* data() const override {
return data_;
}

size_t length() const {
size_t length() const override {
return length_;
}

Expand Down

0 comments on commit 752585d

Please sign in to comment.