Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(other): Add Auth support #7878

Merged
merged 19 commits into from
Jul 11, 2024
Merged

feat(other): Add Auth support #7878

merged 19 commits into from
Jul 11, 2024

Conversation

Ehesp
Copy link
Member

@Ehesp Ehesp commented Jul 5, 2024

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 11:22pm

@Ehesp Ehesp changed the title feat(other): add App/Core support feat(other): add Auth support Jul 5, 2024
@Ehesp Ehesp changed the title feat(other): add Auth support feat(other): Add Auth support Jul 5, 2024
Base automatically changed from refactor-jet-tests to feat-other-platforms July 7, 2024 21:42
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.10%. Comparing base (020e7b8) to head (b2574be).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feat-other-platforms    #7878      +/-   ##
========================================================
+ Coverage                 68.77%   69.10%   +0.34%     
========================================================
  Files                       151      151              
  Lines                      6015     6016       +1     
  Branches                   1265     1265              
========================================================
+ Hits                       4136     4157      +21     
+ Misses                     1784     1768      -16     
+ Partials                     95       91       -4     

Base automatically changed from feat-other-platforms to main July 9, 2024 02:46
@Salakar Salakar marked this pull request as ready for review July 11, 2024 23:23
@Salakar Salakar merged commit 54befe7 into main Jul 11, 2024
17 of 19 checks passed
@Salakar Salakar deleted the web/auth branch July 11, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants