Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-check): build config plugin #7704

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix(app-check): build config plugin #7704

merged 1 commit into from
Mar 25, 2024

Conversation

chsdwn
Copy link
Contributor

@chsdwn chsdwn commented Mar 25, 2024

Description

This PR fixes the CommandError: Cannot find module './plugin/build' error that appears when expo prebuild command is executed. It builds the config plugin after the @react-native-firebase/app-check package is installed.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 11:48am

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix thank you!
I don't use expo personally (as noted in a few places) so I really rely on Expo community folks for the contributions, it's much appreciated

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #7704 (79a22e8) into main (b742500) will decrease coverage by 34.76%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7704       +/-   ##
===========================================
- Coverage   68.13%   33.37%   -34.76%     
===========================================
  Files         150      252      +102     
  Lines        5977    12497     +6520     
  Branches     1257     1951      +694     
===========================================
+ Hits         4072     4169       +97     
- Misses       1808     8239     +6431     
+ Partials       97       89        -8     

@mikehardy mikehardy merged commit 873130c into invertase:main Mar 25, 2024
15 of 17 checks passed
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Mar 25, 2024
@mikehardy
Copy link
Collaborator

This just released, cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔥 [🐛] Cannot find module './plugin/build' for app-check expo config plugin
3 participants