Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support authentication private pub #627

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

VictorOhashi
Copy link
Contributor

@VictorOhashi VictorOhashi commented Jan 9, 2024

Description

Support authentication with private pub repositories.

Resolves: #498

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link

docs-page bot commented Jan 9, 2024

To view this pull requests documentation preview, visit the following URL:

melos.invertase.dev/~627

Documentation is deployed and generated using docs.page.

@VictorOhashi VictorOhashi changed the title Feat: Support authentication private pub feat: Support authentication private pub Jan 9, 2024
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Just some minor comments about naming.

packages/melos/lib/src/common/pub_credential.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/common/http.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/common/pub_credential.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/common/pub_hosted.dart Outdated Show resolved Hide resolved
@VictorOhashi
Copy link
Contributor Author

Good stuff! Just some minor comments about naming.

Thanks for the review. All fixed.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Collaborator

@blaugold blaugold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@blaugold blaugold merged commit dddc7b3 into invertase:main Jan 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: support authentication with private pub repositories
3 participants