Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --no-git-tag-version does not create a commit #622

Closed
1 task done
provokateurin opened this issue Dec 26, 2023 · 2 comments · Fixed by #625
Closed
1 task done

fix: --no-git-tag-version does not create a commit #622

provokateurin opened this issue Dec 26, 2023 · 2 comments · Fixed by #625
Assignees
Labels
bug Something isn't working Type: Accepted

Comments

@provokateurin
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Version

3.4.0

Description

According to the name and the description --no-git-tag-version should only prevent creating git tags and not the commit that is normally generated when using melos version.

Steps to reproduce

  1. melos version --no-git-tag-version
  2. git log
  3. git status

Expected behavior

There should be a new commit, no git tags and no uncommitted changes.

Screenshots

No response

Additional context and comments

No response

@provokateurin
Copy link
Author

Thanks a lot ❤️

@spydon
Copy link
Collaborator

spydon commented Jan 11, 2024

Thanks a lot ❤️

No problem, we'll release this in v4.0.0 later today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Type: Accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants