Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "--no-example" arg to "pub get " command for melos bootstrap #604

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

ankiimation
Copy link
Contributor

@ankiimation ankiimation commented Nov 27, 2023

Description

Usage

melos bs --no-example

Type of Change

  • [ x] ✨ feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

- add ``` --no-example ``` arg for ```dart/flutter pub get``` of bootstrap command
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

@ankiimation ankiimation changed the title add "--no-example" arg to "pub get " command for melos bootstrap feat: add "--no-example" arg to "pub get " command for melos bootstrap Nov 27, 2023
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, missing docs and tests though.

@ankiimation
Copy link
Contributor Author

updated relative url

@spydon
Copy link
Collaborator

spydon commented Dec 18, 2023

@ankiimation could you add some docs to https://github.com/invertase/melos/blob/main/docs/commands/bootstrap.mdx and then we can merge this? :)

@ankiimation
Copy link
Contributor Author

@ankiimation could you add some docs to https://github.com/invertase/melos/blob/main/docs/commands/bootstrap.mdx and then we can merge this? :)

udpated 💪

@spydon spydon merged commit 8b69f51 into invertase:main Dec 18, 2023
10 checks passed
Salakar pushed a commit that referenced this pull request Dec 29, 2023
#604)

* add --no-example arg for melos bs

- add ``` --no-example ``` arg for ```dart/flutter pub get``` of bootstrap command

* fix: set "noExample" param to optional

* add document for ```--no-example``` flag

---------

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants