Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove browser test suite #1536

Closed
Jameskmonger opened this issue Oct 3, 2023 · 5 comments · Fixed by #1542
Closed

Remove browser test suite #1536

Jameskmonger opened this issue Oct 3, 2023 · 5 comments · Fixed by #1542

Comments

@Jameskmonger
Copy link
Member

The browser test suite is no longer functional

PhantomJS has not been supported since 2018 so I suggest we remove this test suite.

I'm not convinced there's much value in a specific set of browser tests anyway, given that our bundling mechanisms aren't necessarily the same as our users'.

@Jameskmonger
Copy link
Member Author

Inviting feedback on this for the next few days, in the absence of any feedback I will be removing the faulty pipeline to unblock PR #1531

cc @inversify/maintainers @inversify/collaborators @PodaruDragos @dcavanagh

@PodaruDragos
Copy link
Contributor

PodaruDragos commented Oct 3, 2023

+1 from me. If we ever need browser tests, we can always just use a different maintained framework like puppeteer.

@remojansen
Copy link
Member

+1 For context when the browser tests were added was a time in which we still had IE and browser compatibility was still a very big issue. I don't think is relevant today.

@acald-creator
Copy link

acald-creator commented Oct 6, 2023

+1 from me, no argument here

@Jameskmonger
Copy link
Member Author

Thanks for the feedback @PodaruDragos @remojansen @acald-creator

I will get on this this morning 😄

Jameskmonger added a commit that referenced this issue Oct 14, 2023
closes #1536, see there for reasoning + discussion
Jameskmonger added a commit that referenced this issue Oct 14, 2023
closes #1536, see there for reasoning + discussion
Jameskmonger added a commit that referenced this issue Oct 15, 2023
closes #1536, see there for reasoning + discussion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants