Merge branch 'master' into cicd/add-bug-and-community-ideas-form

inversify · Oct 22, 2024 · 16c6d8f · 16c6d8f
2 parents 70fc24d + 6e97383
commit 16c6d8f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -31,9 +31,10 @@ jobs:
       - name: Run tests
         run: npm test --coverage
       - name: Store code coverage report
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: coverage
+          overwrite: true
           path: coverage/
 
   Build:
@@ -61,6 +62,7 @@ jobs:
 
   Upload_Coverage_Report:
     name: Upload coverage report to codecov
+    environment: CI
     needs: [Testing]
     runs-on: ubuntu-latest
     steps:
@@ -74,7 +76,8 @@ jobs:
           name: coverage
           path: coverage/
       - name: Codecov Upload
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         with:
           directory: coverage/
           fail_ci_if_error: true
+          token: ${{ secrets.CODECOV_TOKEN }}
diff --git a/src/planning/planner.ts b/src/planning/planner.ts
@@ -3,7 +3,7 @@ import * as ERROR_MSGS from '../constants/error_msgs';
 import { BindingTypeEnum, TargetTypeEnum } from '../constants/literal_types';
 import * as METADATA_KEY from '../constants/metadata_keys';
 import { interfaces } from '../interfaces/interfaces';
-import { isStackOverflowExeption } from '../utils/exceptions';
+import { isStackOverflowException } from '../utils/exceptions';
 import { circularDependencyToException, getServiceIdentifierAsString, listMetadataForTarget, listRegisteredBindingsForServiceIdentifier } from '../utils/serialization';
 import { Context } from './context';
 import { Metadata } from './metadata';
@@ -236,7 +236,7 @@ function plan(
     return context;
   } catch (error) {
     if (
-      isStackOverflowExeption(error)
+      isStackOverflowException(error)
     ) {
       circularDependencyToException(context.plan.rootRequest);
     }

diff --git a/src/utils/exceptions.ts b/src/utils/exceptions.ts
@@ -1,6 +1,6 @@
 import * as ERROR_MSGS from '../constants/error_msgs';
 
-export function isStackOverflowExeption(error: unknown): error is RangeError {
+export function isStackOverflowException(error: unknown): error is RangeError {
   return (
     error instanceof RangeError ||
     (error as Error).message === ERROR_MSGS.STACK_OVERFLOW
@@ -11,7 +11,7 @@ export const tryAndThrowErrorIfStackOverflow = <T>(fn: () => T, errorCallback: (
   try {
     return fn();
   } catch (error) {
-    if (isStackOverflowExeption(error)) {
+    if (isStackOverflowException(error)) {
       error = errorCallback();
     }
     throw error;