Custom options for reusable params blocks

[mibon]

No description provided.

[dblock]

I like it. This needs a CHANGELOG update, please. And I think it could maybe use some elaborating in README. Thx.

[mibon]

Hi. I pushed updates to changelog. Seems like readme already have description of this feature here https://github.com/mibon/grape/commit/4742bbd0fe3a0a2904261c458e45b9dd97d883a2

[dblock]

Looked at this more carefully. The spec actually doesn't test that the values of the options are passed through and reused at all. I suggest reverting the test changes you've done so far that conflate two separate goals of the test and adding something like this:

      context 'with block' do
        before do
          subject.helpers do
            params :order do |options|
              optional :order, type: Symbol, values: [:asc, :desc], default: options[:default_order]
              optional :order_by, type: Symbol, values: options[:order_by], default: options[:default_order_by]
            end
          end
        end

        it 'evaluates options' do
          subject.params do
            use :order, default_order: :asc, order_by: [:name, :created_at], default_order_by: :created_at
          end
          expect(subject.settings[:declared_params]).to eq [:order, :order_by]
          # TODO: test here that :order defaults to :asc and that order_by values are :name and :created_at as well as the default being :created_at
        end
      end

[mibon]

I have no idea how to test it. default parameter and possible values are stored as instance variables in validators classes. Of course I can do something like instance_variable_get, but I hope that you can help me with more delicate solution

[dblock]

Merged via 943d56b. See my changes in both README and specs. Thanks for contributing!