Make endpoint and helpers available in auth blocks #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this change. It addresses a number of things that Grape cannot do today, therefore those need to be implemented in tests. Write one for every single thing the change is fixing please. Also do update CHANGELOG. |
|
@dblock I added some tests that demonstrate the scope of what the basic authentication block has access to. |
|
Thanks, merged via e23069a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates make the endpoint instance the context (or "self") for auth blocks such as Basic Authentication and Digest Authentication. It also extends the instance earlier to make helper methods available to Rack middleware. This allows us to authenticate and store info related to authentication as part of the request (e.g. instance variables or environment variables).