Don't allow to have nil value when required & have allowed values. #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please update CHANGELOG ( |
|
Uhm, 0.6.1 has been released, add it to the Next Release section pls. |
|
OK, sorry, done. |
|
Last thing, promise, put back the "* Your contribution here.", please, for the next contributor. Thanks so much for contributing, sorry for being a pest. |
This fixes the case when we want to filter nil values in params, and we provide allowed values using ValuesValidator.
|
Did that. You should write a tutorial how to contribute here 😉 |
|
Thanks! You can contribute a tutorial :) |
dblock
added a commit
that referenced
this pull request
Oct 24, 2013
…dator Don't allow to have nil value when required & have allowed values.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case when we want to filter nil values in params,
and we provide allowed values using ValuesValidator.