Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goliath passes request header keys as symbols #408

Merged
merged 1 commit into from Jun 2, 2013
Merged

goliath passes request header keys as symbols #408

merged 1 commit into from Jun 2, 2013

Conversation

bobek
Copy link
Contributor

@bobek bobek commented May 18, 2013

Hi,

goliath passes key in headers hash as symbols. This trivial patch fixes the undefined start_with for symbol error otherwise causing crash of the app.

Antonin

@dblock
Copy link
Member

dblock commented May 18, 2013

Can you please write a test for this and update CHANGELOG. Thank you.

@dblock
Copy link
Member

dblock commented Jun 2, 2013

Ping @bobek. I want this, but I also want it with a test / changelog update. Want to do it?

@bobek
Copy link
Contributor Author

bobek commented Jun 2, 2013

Hi @dblock , can you please check the new commit? I didn't find any less hackinsh way how to modify env before hitting the Endpoint in the test.

@dblock
Copy link
Member

dblock commented Jun 2, 2013

Totally clean in my world, merging.

dblock added a commit that referenced this pull request Jun 2, 2013
goliath passes request header keys as symbols
@dblock dblock merged commit 948696f into ruby-grape:master Jun 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants