Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citylearn challenge 2023 power outage env #90

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

kingsleynweye
Copy link
Member

Description

Bug fixes in storage charge function and episode start and end time step selection.

Issue

NIL

Changes

  • Updated docstring in ReliabilityMetricsPowerOutage
  • Fixed bug in Storage.charge where round-trip efficiency was being applied to both energy_init and energy as a result of controller action instead of the latter alone.
  • Fixed bug where it was not possible to maintain ideal cooling or heating load when cooling_device or heating_device was not controlled.
  • Fixed bug where episode splits were not being properly selected for simulations where single dataset has multiple episode splits defined.

Screenshots

NIL

Checklist

  • I have tested the changes locally and they work as intended.
  • I have updated the documentation, if applicable.
  • I have added new tests, if applicable.
  • I have added any required dependencies to the requirements.txt file, if applicable.
  • I have followed the project's code style and conventions.

Additional notes

Please provide any additional information that may be helpful for the reviewer.

@kingsleynweye kingsleynweye merged commit 4e702f4 into master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant