Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue in dtype of grid in cleaner env #217

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

raphaelavalos
Copy link
Contributor

Hello,

I found a bug in the cleaner environment. The dtype of the grid was incorrect and it was failing the tests. The alternative fix would be to change the spec of the grid to int32.

Best,
Raphael

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2024

CLA assistant check
All committers have signed the CLA.

@clement-bonnet
Copy link
Collaborator

clement-bonnet commented Jan 16, 2024

Hi @raphaelavalos, good catch, thank you! Indeed, the grid is of type int8. I am happy with your fix. However, it would be helpful if we could fix the documentation at the same time.

  • The Cleaner class docstring mentions int32 instead of int8 for the grid.
  • The documentation readme at docs/environments/cleaner.md shows int instead of int8.

Would you please be able to bring these changes as well? 🙏

@raphaelavalos
Copy link
Contributor Author

Hi @clement-bonnet,
I included the docstring and docs modifications 😄

Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clement-bonnet clement-bonnet merged commit 8168c5c into instadeepai:main Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants