Feature/fix sampler madqn #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdanToledo
requested review from
arnupretorius,
KaleabTessera,
DriesSmit,
mmorris44,
AsadJeewa,
RuanJohn and
jcformanek
as code owners
DriesSmit
reviewed
Apr 12, 2022
DriesSmit
reviewed
Apr 12, 2022
There was a problem hiding this comment.
Thanks @EdanToledo🙂 See my few comments. Also, I see the checks are failing?
...tf/debugging/simple_spread/feedforward/decentralised/run_maddpg_scale_trainers_fixed_nets.py
Outdated
Show resolved
Hide resolved
sash-a
reviewed
Apr 12, 2022
sash-a
reviewed
Apr 12, 2022
|
I see I made my comments on the ddpg changes, seems like that shouldn't be in this PR, but the same goes for DQN. Other than the minor variable/method name changes, all looks good |
DriesSmit
approved these changes
Apr 22, 2022
sash-a
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes multiple trainers, for different agents with different architectures for madqn
Why?
So that mava can be used for hierarchical reinforcement learning
How?
Implements @DriesSmit code in MADQN