Bugfix/ Release aren't triggering pypi push job. #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t when it is created.
KaleabTessera
requested review from
arnupretorius,
DriesSmit,
mmorris44,
AsadJeewa,
RuanJohn and
jcformanek
as code owners
arnupretorius
previously approved these changes
Mar 25, 2022
RuanJohn
previously approved these changes
Mar 25, 2022
DriesSmit
previously approved these changes
Mar 25, 2022
KaleabTessera
dismissed stale reviews from DriesSmit, RuanJohn, and arnupretorius
via
0db5892
DriesSmit
approved these changes
Mar 28, 2022
RuanJohn
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changed pypi job to be triggered whenever a release is
publishedand not justcreated. For some reason, currently it appears that github thinks release 0.1.2 has ready been created and hence won't trigger the pypi job. Changing this to work on whenever a release isreleasedseems better practice (https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#release , https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release).Why?
Release aren't triggering pypi push job.
How?
Extra
Seems related to this actions/starter-workflows#554 .