fix: small bug in the pettingzoo wrapper related to legal action masking #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcformanek
requested review from
arnupretorius,
KaleabTessera,
DriesSmit,
mmorris44,
AsadJeewa and
RuanJohn
as code owners
|
@AsadJeewa see the fixes here. |
arnupretorius
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
Looks good to me. Thanks @jcformanek 👍
We should just benchmark to make sure it is working as expected.
|
Thanks for the quick fix @jcformanek |
AsadJeewa
approved these changes
Feb 24, 2022
mmorris44
reviewed
Feb 24, 2022
mmorris44
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The legal action mask in pettingzoo Pong was causing the madqn example to fail. This is because MADQN expects the legal action mask to be a vector of ones and zeros specifying for each action if it is a valid action or not. The pettingzoo wrapper was returning only a single one value for the legal action mask.
Also fixed problem in TicTacToe example. The MADQN executor needs a
select_actionmethod for single agents.Why?
The MADQN example on Pong was failing.
How?
Simple fix in the pettingzoo wrapper.
MADQN needs
select_actionmethod for single agents in sequential games like Tic Tac Toe.Extra
N/A