Feature/jax general system class #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnupretorius
requested review from
KaleabTessera and
DriesSmit
as code owners
arnupretorius
requested review from
mmorris44,
AsadJeewa,
RuanJohn and
jcformanek
as code owners
KaleabTessera
previously approved these changes
Mar 8, 2022
AsadJeewa
previously approved these changes
Mar 8, 2022
arnupretorius
dismissed stale reviews from AsadJeewa and KaleabTessera
via
8910ee8
RuanJohn
reviewed
Mar 9, 2022
AsadJeewa
previously approved these changes
Mar 9, 2022
RuanJohn
previously approved these changes
Mar 9, 2022
AsadJeewa
approved these changes
Mar 9, 2022
KaleabTessera
approved these changes
Mar 9, 2022
RuanJohn
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
General system class for Jax-based Mava systems.
Why?
The new system class supports a more general and flexible build system using callback components.
How?
Create a system class with functions for specifying a system design using components and adding, updating and configuring system component hyperparameters.
Extra
I'm experiencing a tricky mypy issue that I haven't been able to solve. It has to do with the
Builderattributes not being picked up even though the tests seem to indicate that the system and builder interact as expected. This is also the case with theCallbackHookMixin. @KaleabTessera perhaps you might have some ideas once you have looked at the code?closes #406