Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move examples into tf folder and update examples links #416

Merged
merged 3 commits into from
Feb 17, 2022
Merged

refactor: move examples into tf folder and update examples links #416

merged 3 commits into from
Feb 17, 2022

Conversation

arnupretorius
Copy link
Collaborator

@arnupretorius arnupretorius commented Feb 17, 2022 •
edited
Loading

What?

Move examples into TF folder.

Why?

Separate current examples from future Jax examples.

closes #415

@arnupretorius arnupretorius added the maintenance General improvements/optimisations label Feb 17, 2022
@arnupretorius arnupretorius self-assigned this Feb 17, 2022
KaleabTessera
KaleabTessera approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@KaleabTessera KaleabTessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnupretorius 👍

AsadJeewa
AsadJeewa approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@AsadJeewa AsadJeewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arnu

RuanJohn
RuanJohn approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@RuanJohn RuanJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnupretorius! 🤙

DriesSmit
DriesSmit approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@DriesSmit DriesSmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnupretorius 😄

@arnupretorius arnupretorius merged commit 511bc5f into develop Feb 17, 2022
@arnupretorius arnupretorius deleted the maintenance/move-tf-examples branch February 17, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaleabTessera KaleabTessera KaleabTessera approved these changes

@AsadJeewa AsadJeewa AsadJeewa approved these changes

@DriesSmit DriesSmit DriesSmit approved these changes

@RuanJohn RuanJohn RuanJohn approved these changes

@mmorris44 mmorris44 Awaiting requested review from mmorris44

@jcformanek jcformanek Awaiting requested review from jcformanek jcformanek is a code owner

Assignees

@arnupretorius arnupretorius

Labels
maintenance General improvements/optimisations size/XXL
Projects
None yet
Milestone
Jax Mava release
Development

Successfully merging this pull request may close these issues.

[MAINTAIN] Split example up into TF and Jax
5 participants
@arnupretorius @KaleabTessera @AsadJeewa @DriesSmit @RuanJohn