Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Dockerfile for SMAC installation #286

Merged
merged 1 commit into from
Aug 3, 2021
Merged

update Dockerfile for SMAC installation #286

merged 1 commit into from
Aug 3, 2021

Conversation

mnguyen0226
Copy link
Contributor

What?

[Describe what was changed and reference relevant issue.]
From Pull Request: #284

This modification related to the issue when install Docker for SMAC: #282

I tried to install Docker to both Python 3.6 and Python 3.7 and figure out that pysc2 needed as well as uninstall enum34 is needed before pip install oxwhiri/smac github repo to prevent enum-Python 3.6 error. Note that there are suggestion for update enum instead of uninstall but this will not work

Why?

[Describe why the change was made.]
To be able to install Docker on Python 3.6, 3.7 correctly

How?

[Describe how the change was made i.e. describe technically what the change does.]
Shown below

Extra

[Any extra information.]
Also, I suggested to update the main Docker repo to up-to-date with the develop one since it does not have uninstall enum and it cause problem in install Docker.

I know that develop is a default git clone but many user might still try to use main branch instead

@KaleabTessera
Copy link
Contributor

Congrats on your first PR @mnguyen0226 . This is much appeciated! :)

@KaleabTessera KaleabTessera merged commit e6d0ea8 into instadeepai:develop Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants