Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/ Smac Load #283

Merged
merged 3 commits into from
Jul 28, 2021
Merged

fix/ Smac Load #283

merged 3 commits into from
Jul 28, 2021

Conversation

KaleabTessera
Copy link
Contributor

What?

  • Fix SC2 load errors.
  • Make system tests use one executor for more consistency.

Why?

How?

Extra

@KaleabTessera KaleabTessera changed the title Feature/fix tests Feature/fix Smac Load Jul 28, 2021
@KaleabTessera KaleabTessera changed the title Feature/fix Smac Load fix/ Smac Load Jul 28, 2021
arnupretorius
arnupretorius approved these changes Jul 28, 2021
View reviewed changes
Copy link
Collaborator

@arnupretorius arnupretorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KaleabTessera! 👍

@arnupretorius arnupretorius merged commit 0b126f7 into develop Jul 28, 2021
@arnupretorius arnupretorius deleted the feature/fix-tests branch July 28, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnupretorius arnupretorius arnupretorius approved these changes

@DriesSmit DriesSmit Awaiting requested review from DriesSmit DriesSmit is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaleabTessera @arnupretorius