feat: integration tests #1070
Merged
feat: integration tests #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sash-a
force-pushed
the
feat/integ-tests
branch
from
fab9231
to
325b411
Compare
sash-a
requested review from
arnupretorius,
DriesSmit,
RuanJohn,
jcformanek,
siddarthsingh1,
OmaymaMahjoub,
ulricharmel,
callumtilbury and
WiemKhlifi
as code owners
WiemKhlifi
previously requested changes
Jul 22, 2024
There was a problem hiding this comment.
Thanks @sash-a! It's really satisfying to see my chaotic shell script evolve into a more sophisticated and cleaner test version 😅💃
Co-authored-by: Ruan de Kock <33461981+RuanJohn@users.noreply.github.com>
OmaymaMahjoub
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Thanks @sash-a, I made a final optional request, If you believe it's unnecessary, feel free to ignore it 😅
sash-a
dismissed
WiemKhlifi’s stale review
stale, comments addressed and 2 approving reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds integration tests
todo:
closes #1049