-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide SPI for modules so there might be developed independently #4
Comments
Hi, @smiklosovic , any news on this feature? I wanted to list backups via Icarus operations but haven't found one, so I thought implementing my own, but don't really want to change the source code |
Hi, listing of backups is already there. (1), (2), (3). I am not sure if this module is in Icarus but it should be. I have not tested listing via Icarus. Feel free to test it out and let me know if it works. (1) https://github.com/instaclustr/esop#listing-of-backups |
Yeah, I didn't check for this module in Esop, but it looks like it's not added to Icarus, at least I cannot find it in here https://github.com/instaclustr/icarus/blob/master/src/main/java/com/instaclustr/icarus/Icarus.java And trying to call this operation to Icarus fails:
Response:
|
@2ban could you add it there, test it and create a pull request, please? |
@2ban I added that module, built JAR is uploaded here: |
@smiklosovic great, thanks! |
Is your feature request related to a problem? Please describe.
I would like to be able to implement modules and use them without actually merging them into the code base.
Describe the solution you'd like
There needs to be a SPI provided / implemented so mere placing of an implementation to class path will result in an operation module being instantiated and registered upon Icarus starting.
The text was updated successfully, but these errors were encountered: