Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resample: refactor default output step size calculation #997

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Apr 25, 2023

Description of proposed changes

  • rename utils.utils0.auto_lat_lon_step_size() to objects.resample.resample.get_lat_lon_step()

    • move the location because this function is only used in the resample code so far
    • add the user-specified lalo_step code body into this function, for a more simple prepare_geometry_definition_radar()
    • replace try/except with if/else and explicit required metadata checking and warning msg
  • objects.resample.resample.prepare_geometry_definition_radar.find_valid_lat_lon():

    • rename mark_lat_lon_anomaly() to find_valid_lat_lon()
    • add more comments on the input/output args
  • cli.geocode: set default fillValue to zero for .int/unw files, to be consistent with isce/roipac.

  • docs/api/module_hierarchy.md: update for objects.resample.py

  • objects.progress.FileProgressObject(): display in int MB to be simple

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ rename utils.utils0.auto_lat_lon_step_size() to objects.resample.resample.get_lat_lon_step()
   - move the location because this function is only used in the resample code so far
   - add the input lalo_step code body into this function, for a more simple code in the workflow
   - replace try/except with if/else and explicit required metadata checking and warning msg

+ objects.resample.resample.prepare_geometry_definition_radar.find_valid_lat_lon():
   - rename mark_lat_lon_anomaly() to find_valid_lat_lon()
   - add more comments on the input/output args

+ cli.geocode: set default fillValue to zero for .int/unw files, to be consistent with isce/roipac.

+ docs/api/module_hierarchy.md: update for objects.resample.py

+ objects.progress.FileProgressObject(): display in int MB to be simple
@yunjunz yunjunz merged commit a5d8696 into insarlab:main Apr 25, 2023
@yunjunz yunjunz deleted the resample branch April 25, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant