Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view: add --scalebar-linewidth option #1111

Merged
merged 1 commit into from
Oct 27, 2023
Merged

view: add --scalebar-linewidth option #1111

merged 1 commit into from
Oct 27, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Oct 27, 2023

Description of proposed changes

  • view: add --scalebar-linewidth option

  • prep_gamma: fix the inps.sensor.lower() issue when sensor is not specified, i.e. inps.sensor is None, by shifting the lower() operation inside extract_metadata4interferogram()

  • asc_desc2horz_vert.get_design_matrix4east_north_up(): add type checking for the obs_direction arg.

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ view: add --scalebar-linewidth option

+ prep_gamma: fix the `inps.sensor.lower()` issue when sensor is not specified, i.e. inps.sensor is None, by shifting the lower() operation inside `extract_metadata4interferogram()`

+ asc_desc2horz_vert.get_design_matrix4east_north_up(): add type checking for the `obs_direction` arg.
@yunjunz yunjunz merged commit 07b4628 into insarlab:main Oct 27, 2023
7 checks passed
@yunjunz yunjunz deleted the view branch October 27, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant